GitPR – vixIT

Zusammenfassung

Der Pull Request fügt einen Senseair/Sunrise CO₂-Sensor-Treiber in das Zephyr-Sensor-Modul-Repository ein. Im Verlauf wurden Kconfig, CMake, README, Device-Tree-Bindings, Quellcode, Header-Datei und die Ordnerstruktur überarbeitet.

Alle sichtbaren Einträge

◆

Initialer Commit Aug 27, 2021

phim eröffnete den PR mit dem Commit bff538d.

added sunrise_sensor bff538d

👁

Review angefragt Aug 27, 2021 11:36

phim requested a review from neye.

neye suggested changes Aug 30, 2021

Review mit mehreren Datei-Kommentaren.

sunrise_sensor/Kconfig sunrise_sensor/CMakeLists.txt sunrise_sensor/Kconfig sunrise_sensor/README.md sunrise_sensor/README.md sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/src/sunrise_co2_sensor.c

neye suggested changes Aug 30, 2021

Weiterer Review-Kommentar zur Header-Datei.

sunrise_sensor/src/sunrise_co2_sensor.h

↑

phim and others added 11 commits Aug 31, 2021 10:05

11 Commits anzeigen

changed several things regarding pullrequestca86667
break lines934ddb0
send only address at wake up6b73d36
update readme and changed ifdef in CMakeLists.txt55c3e30
replaced unnecessary read/write funcs with i2c-funcs50ca752
add switch(chan) in sample_fetch80faad0
extract gpio to dts49b9156
add dependencies in Kconfig03329be
split gpio pins6442db9
Merge branch 'co2' of github.zhaw.ch:InESTeamIOT/zephyr_sensor_module… into co27a740ac
update readme.mdc1a595c

👁

neye self-requested a review Sep 7, 2021 11:12

neye forderte selbst erneut ein Review an.

✓

neye reviewed Sep 7, 2021

Review mit weiteren Datei-Kommentaren.

sunrise_sensor/CMakeLists.txt sunrise_sensor/README.md sunrise_sensor/README.md sunrise_sensor/dts/bindings/senseair,sunrise.yaml sunrise_sensor/dts/bindings/senseair,sunrise.yaml sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/README.md sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/src/sunrise_co2_sensor.c sunrise_sensor/src/sunrise_co2_sensor.h

💬

neye commented Sep 7, 2021

rename the folder to senseair_sunrise

↑

phim added 12 commits Sep 7, 2021 16:12

12 Commits anzeigen

change chip_temp to signeda936fd0
several changes8b0e019
update README.md5fbaea3
updated overlay sectionea3140f
set rc = 0 and return rc2193165
renamed folderbce9aaa
add interrupt, adapt sunrise_get_measured_sampledd4f33e
correct return -EINVAL948a033
break linese1bc572
Update README.mdd441128
[README.md] add link4e49e67
move k_sem_take to sunrise_sample_fetch823d254

◆

Weiterer Commit Sep 7, 2021

removed k_sleep9d2410d

👁

neye self-requested a review Sep 13, 2021 16:11

neye forderte nochmals selbst ein Review an.

✓

neye approved these changes Sep 13, 2021

Approved Review mit letzten Datei-Kommentaren.

senseair_sunrise/README.md senseair_sunrise/README.md senseair_sunrise/README.md senseair_sunrise/src/sunrise_co2_sensor.h senseair_sunrise/src/sunrise_co2_sensor.h senseair_sunrise/src/sunrise_co2_sensor.c

💬

neye commented Sep 13, 2021

Looks good now.

Implement the comments I just added and then “Squash and merge” the PR.

I suggest using this commit message:

Add driver for senseair sunrise CO2 sensor

↑

phim and others added 4 commits Sep 13, 2021 16:46

4 Commits anzeigen

Update senseair_sunrise/README.md — Co-authored-by: neye7169506
[README.md] remove else & clock-freq40086db
[sunrise_co2_sensor.h] remove comment — Co-authored-by: neye833998d
[sunrise_co2_sensor.h] remove line — Co-authored-by: neye7a94088

✓

neye reviewed Sep 13, 2021

Weiterer Review-Eintrag.

senseair_sunrise/README.md

✓

neye reviewed Sep 14, 2021

Finaler Review-Eintrag vor dem Merge.

senseair_sunrise/README.md

↑

phim and others added 2 commits Sep 14, 2021 16:42

2 Commits anzeigen

remove comments9578cb8
add clock again — Co-authored-by: neyeca36c38

✓

Merged Sep 14, 2021

phim merged commit 902816b into master.

Branch gelöscht Mar 8, 2022 16:01

phim deleted the co2 branch.